-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #279
Update README.md #279
Conversation
Improve the README to make it easier to find different logging backends
@@ -60,9 +60,9 @@ LoggingSystem.bootstrap(StreamLogHandler.standardError) | |||
For further information, please check the [API documentation][api-docs]. | |||
|
|||
<a name="backends"></a> | |||
#### Selecting a logging backend implementation (applications only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the (applications only) part is important so we should find a place to say that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@swift-server-bot add to allowlist |
Make it explicit that backends are for applications
fixing CI in #281 |
@swift-server-bot test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we forgot tom merge here, looks good LGTM
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [apple/swift-log](https://togithub.com/apple/swift-log) | patch | `from: "1.5.3"` -> `from: "1.5.4"` | --- ### Release Notes <details> <summary>apple/swift-log (apple/swift-log)</summary> ### [`v1.5.4`](https://togithub.com/apple/swift-log/releases/tag/1.5.4) [Compare Source](https://togithub.com/apple/swift-log/compare/1.5.3...1.5.4) ##### What's Changed ##### Cleanups & minor compatibility improvements - Don't assume localtime() result is non-nil by [@​gwynne](https://togithub.com/gwynne) in [apple/swift-log#280 - Changes to build with Musl. by [@​al45tair](https://togithub.com/al45tair) in [apple/swift-log#283 ##### Non code changes - Add CocoaLumberjack to list of logging backends by [@​ffried](https://togithub.com/ffried) in [apple/swift-log#276 - update CI script by [@​tomerd](https://togithub.com/tomerd) in [apple/swift-log#281 - Update README.md by [@​0xTim](https://togithub.com/0xTim) in [apple/swift-log#279 ##### New Contributors - [@​ffried](https://togithub.com/ffried) made their first contribution in [apple/swift-log#276 - [@​0xTim](https://togithub.com/0xTim) made their first contribution in [apple/swift-log#279 - [@​al45tair](https://togithub.com/al45tair) made their first contribution in [apple/swift-log#283 **Full Changelog**: apple/swift-log@1.5.3...1.5.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Make it easier to find the section about different logging backends. It's currently buried in a level 4 heading which doesn't make much sense. Also tweak the language as it's a reasonably mature ecosystem now