Make Curve25519 PublicKey
s conform to Hashable
#175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Curve25519 PublicKeys conform to
Hashable
N.B. Merge open PR #173 first (or if #173 is closed, close this one too), since this PR builds on top of that.
Checklist
If you've made changes to
gyb
files.script/generate_boilerplate_files_with_gyb
and included updated generated files in a commit of this pull requestMotivation:
PublicKey's are fundamental building blocks within EC-oriented code bases. They can act as a natural key in Dictionaries and otherwise important property of larger structs, which us developers often would like to make
Hashable
. Today, Curve25519 public keys prevent auto-synthesis ofHashable
for any structs they are members of, thus Curve25519 keys ought to beHashable
!This poses no security risk nor any performance downgrade.
This PR is an addition of open PR #173.
Modifications:
Curve25519.KeyAgreement.PublicKey
andCurve25519.Signing.PublicKey
have been madeHashable
and unit tests have been added.Result:
Curve25519.KeyAgreement.PublicKey
andCurve25519.Signing.PublicKey
are nowHashable