Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backchannel status checking bugs #6085

Closed
wants to merge 1 commit into from
Closed

Fix backchannel status checking bugs #6085

wants to merge 1 commit into from

Conversation

AtariDreams
Copy link
Contributor

Checking for merely (status < 0) is a bug because the check for timeout is deliberate.

Note that you have an if (timeout < 0) at the beginning

So if the timeout is set to a value, it should check for that value.

Co-Authored-By: aaaaaa123456789 [email protected]

Checking for merely (status < 0) is a bug because the check for timeout is deliberate.

Note that you have an if (timeout < 0) at the beginning

So if the timeout is set to a value, it should check for that value.

Co-Authored-By: aaaaaa123456789 <[email protected]>
@AtariDreams
Copy link
Contributor Author

@salgernon @michaelrsweet Please take a look at this and tell me if this if correct or the way it was before is intentional, considering the way I changed it to is written in the cupsBackChannelWrite function

@AtariDreams AtariDreams closed this by deleting the head repository Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant