Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix _cupsGet1284Values #5972

Closed
wants to merge 1 commit into from
Closed

fix _cupsGet1284Values #5972

wants to merge 1 commit into from

Conversation

AtariDreams
Copy link
Contributor

Synced from upstream

Copy link
Collaborator

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've included a bunch of additional changes of your own, not just the original fix for _cupsGet1284Values.

break;

if (i)
if (name && num_options > 0 && options)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not part of the original 1284 fix...

@michaelrsweet
Copy link
Collaborator

Pushed the changes (and ONLY the changes) from OpenPrinting CUPS myself.

@michaelrsweet michaelrsweet self-assigned this Oct 1, 2021
@michaelrsweet michaelrsweet added bug Something isn't working priority-low labels Oct 1, 2021
@michaelrsweet michaelrsweet added this to the Stable milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants