Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant code #5953

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Remove redundant code #5953

merged 1 commit into from
Sep 7, 2021

Conversation

AtariDreams
Copy link
Contributor

Some of the code is either dead code, redundant, or always true. Meaning they do not do anything since the cases were already dealt with in earlier parts of the code. It would be best to remove this code.

Note that some of the code removal required a tiny bit of refactoring.

michaelrsweet
michaelrsweet requested changes Sep 5, 2021
View reviewed changes
Copy link
Collaborator

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good. You need to leave the NULL function checks in place since on macOS looking for the address of a function is a way to detect the presence of an optional ("weak linked") library.

cups/auth.c Show resolved Hide resolved
scheduler/auth.c Outdated Show resolved Hide resolved
scheduler/colorman.c Outdated Show resolved Hide resolved
scheduler/conf.c Outdated Show resolved Hide resolved
scheduler/ipp.c Outdated Show resolved Hide resolved
systemv/lpstat.c Outdated Show resolved Hide resolved
@michaelrsweet michaelrsweet self-assigned this Sep 5, 2021
@michaelrsweet michaelrsweet added enhancement New feature or request priority-low labels Sep 5, 2021
@michaelrsweet michaelrsweet added this to the Stable milestone Sep 5, 2021
@AtariDreams
Copy link
Contributor Author

All issues addressed!

@michaelrsweet michaelrsweet merged commit 95b7060 into apple:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelrsweet michaelrsweet Awaiting requested review from michaelrsweet

Assignees

@michaelrsweet michaelrsweet

Labels
enhancement New feature or request priority-low
Projects
None yet
Milestone
Stable
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AtariDreams @michaelrsweet