Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _CUPS_NORETURN to missing functions #5952

Merged
merged 1 commit into from Sep 5, 2021
Merged

Add _CUPS_NORETURN to missing functions #5952

merged 1 commit into from Sep 5, 2021

Conversation

AtariDreams
Copy link
Contributor

Almost every non-returning function has this qualifier, but not all. This should properly define them all as well as shrink the final binary a little bit.

michaelrsweet
michaelrsweet requested changes Aug 31, 2021
View reviewed changes
Copy link
Collaborator

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments to your OpenPrinting PR - the annotation should go on the prototype, not on the implementation of the function.

@michaelrsweet michaelrsweet self-assigned this Aug 31, 2021
@michaelrsweet michaelrsweet added enhancement New feature or request priority-low labels Aug 31, 2021
@michaelrsweet michaelrsweet added this to the Stable milestone Aug 31, 2021
@AtariDreams
Copy link
Contributor Author

@michaelrsweet anything else?

@michaelrsweet michaelrsweet merged commit 3499fe1 into apple:master Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelrsweet michaelrsweet Awaiting requested review from michaelrsweet

Assignees

@michaelrsweet michaelrsweet

Labels
enhancement New feature or request priority-low
Projects
None yet
Milestone
Stable
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AtariDreams @michaelrsweet