cupsGetDests's behaviour is difference between CUPS2.2.10 & CUPS2.2.12

[tangyanli]

Assume the default printer name is set as below:
/etc/cups/printers.conf: PrinterA
~/.cups/lpoptions: PrinterB

When use the cupsGetDests to get the default printer name:
Ubuntu19.04 (CUPS2.2.10): The PrinterB's dest->is_default = 1
Ubuntu19.10 (CUPS2.2.12): The PrinterA's dest->is_default = 1

I tried to analyze the code, is the cups_enum_dests()'s logic changed?
(1) data.def_name stores the system default name ("PrinterA")
(2) Get the use default name from ~/.cups/lpoptions ("PrinterB")
(3) According the data.def_name ("PrinterA") to set the dest->is_default = 1

getDefaultPrinter.txt

[michaelweghorn]

I didn't test yet, but does merge request #5679 make a difference?

[tangyanli]

CUPS2.2.12 was released at Aug 15. It seems not the #5679 causes the problem.

[michaelweghorn]

CUPS2.2.12 was released at Aug 15. It seems not the #5679 causes the problem.

You're right, #5679 is not even included in any CUPS release, not even in the development version in git. What I meant was that it might possibly fix the issue, since what you describe sounds similar to #5681, and #5679 seemed to fix that one for me in a quick test.

However, I only tested with git master (i.e. CUPS 2.3.X), so your issue might be a different one.

[tangyanli]

I also found another phenomenon as below:

Assume the default printer name is set as below:
/etc/cups/printers.conf: PrinterA
~/.cups/lpoptions: PrinterB
When use lpoptions to set PrinterC's setting:
lpoptions -p PrinterC -o PageSize=A4
↑
The default printer name recorded in the ~/.cups/lpoptions becomes "PrinterA"

And I tried to fix the cups_enum_dests(), the above phenomenon disappears.
Because I am not familiar with CUPS coding, is the fix OK?

dest.txt

[michaelweghorn]

And I tried to fix the cups_enum_dests(), the above phenomenon disappears.
Because I am not familiar with CUPS coding, is the fix OK?

dest.txt

Is "dest.txt" your modified version that contains the fix? I'm not really familiar with CUPS coding either, but I think that creating a pull request would be a better way to suggest a fix, in particular since other places in the file might change in the meantime, making it hard to see what your actual change was by just looking at the attachment.

[tangyanli]

It is OK.
I then will test the newest code from the git to check whether the issue still exists or not.
If still exists, I will pull a request.

BTW: the dest.txt (actually dest.c) is changed based on the CUPS2.2.12 release coding. :-)

[michaelrsweet]

OK, this is a dupe of Issue #5681 - fixes have been pushed to the master and 2.2.x branches.

[tangyanli]

I am sorry, I have tested the branch CUPS2.3.x and CUPS2.2x, this issue is not fixed entirely.