-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why use pwgMediaForPPD() in _ppdCacheCreateWithPPD()? #5633
Comments
I will need to do some digging on this; there was a reason but I don't remember it offhand... :/ |
Well, changing to pwgMediaForSize seems to work, so let's go with it... |
michaelrsweet
added a commit
that referenced
this issue
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a multi-part question prompted by a PPD containing the following
PaperDimension
s:Passing such a PPD under
cupstestppd
shows these warnings:CUPS writes the PPD cache with these
Size
specifications:We have received user feedback reports that selecting either of these media to print with causes the printer to print in JIS B5; the ISO B5 (176x250mm) size is unpickable.
CUPS chooses to represent that B5
PaperDimension
because it calls pwgMediaForPPD() and gets the JIS size out of it. It won't find the ISO B5 size because it calls _pwgMediaNearSize() withepsilon = 0
(17604 != 17600; 25012 != 25000). Even if we increase the epsilon, the selected PWG vendor ID will still only reflect what pwgMediaForPPD() initially chose. I assume this could confuse the printer down the line._ppdCacheCreateWithPPD()
attach importance to the stated PPD media name? Can we get away with matching by size only?epsilon = 0
when calling_pwgMediaNearSize()
? Can we get away with a higher epsilon ascupstestppd
does?The text was updated successfully, but these errors were encountered: