Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer is covering submit button #5574

Closed
scootergrisen opened this issue May 4, 2019 · 3 comments
Closed

footer is covering submit button #5574

scootergrisen opened this issue May 4, 2019 · 3 comments
Assignees

Comments

@scootergrisen
Copy link
Contributor

The footer on localhost:631 uses CSS position:fixed; which is annoying because the footer can be on top of e.g. a submit button that is at the bottom of a page.

<div class="footer">CUPS and the CUPS logo are trademarks of <a href="http:https://www.apple.com">Apple Inc.</a> Copyright &copy; 2007-2018 Apple Inc. All rights reserved.</div>

So if i go to the admin page and click the advanced link and scroll to the bottom of the page i can hardly see the submit button and there is only 4 pixels height area for me to be able to click the button.

button

@michaelrsweet
Copy link
Collaborator

The CSS should be adding a bottom margin to leave space for the footer... Should be an easy fix.

@scootergrisen What browser are you using?

@michaelrsweet michaelrsweet self-assigned this May 6, 2019
@michaelrsweet michaelrsweet added this to the CUPS 2.2.x Updates milestone May 6, 2019
@michaelrsweet
Copy link
Collaborator

Hmm, OK the issue is the split ("responsive") CSS being used on the admin page (and it only affects the admin page). The padding that normally prevents this from happening is not getting used...

@michaelrsweet
Copy link
Collaborator

[master 0e17f4c] Fix CSS on short browsers (Issue #5574)

[branch-2.2 971bdfe] Fix CSS on short browsers (Issue #5574)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants