-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUPS error log should include timeout's in default state. #5570
Comments
I think the basic root cause in this issue here is same as in In both cases by default CUPS does not provide sufficient information |
@jsmeix This issue is different - the application submitting the print job is taking too long to prepare the PDF file for submission, and the timeout isn't getting logged. |
…rror if the job submission times out (Issue #5570)
…rror if the job submission times out (Issue #5570)
For what it's worth, the case in question was NOT a multiple file job, I don't believe. It was a single page (ergo single PDF) that had 25 little images on it (as in a photographer's contact sheet). That's why it took so long to produce. The "fix" (from my side) was to increase the |
@fhcarter There are two timeouts at play here - one between the Create-Job and Send-Document requests, and one during the Send-Document request. I'll double-check that the timeout has been increased for both, but the intent is to log an error whenever a timeout occurs... |
@michaelrsweet Thanks. Just wanted to make the situation clear. The code changes looked like it changed only |
@fhcarter Right, DEFAULT_TIMEOUT is used in a bunch of places for the normal networking timeout value, but in this case MultipleOperationTimeOut is king because it applies to the submission process (how long it takes the document(s) for the job to be submitted) and not to how long cupsd waits for a client to send something over the network. After reviewing the code in scheduler/job.c, it looks like I needed to move things around a bit for the logging to only happen for a timed out job (vs. the hold on the job expiring normally). |
@michaelrsweet OK, thanks. At home tonight, I'll try updating my CUPS config, changing |
@michaelrsweet I tried making the changes you appeared to make via
(I tried 3 times.) However, setting Mojave 10.14.4, CUPS 2.2.9 Attached copy of error log from running in this configuration cupsd.conf:
Hopefully, this helps with diagnostics |
The simplest change here is to just bump the default Timeout value to 900 seconds; the new logging code will still let you know why the timeout occurred for the job, and the increased timeout value will hopefully make these issues non-existent. I looked at tying the in-process IPP request to MultipleOperationTimeout and all other HTTP requests to Timeout, but that seemed too likely to be abused... [master f49af67] Bump the default Timeout to 15 minutes as well (Issue #5570) [branch-2.2 9d6f1bb] Bump the default Timeout to 15 minutes as well (Issue #5570) |
@fhcarter
I guess each of that |
@jsmeix -- Indeed. Approximately half were iPhone 7's, the other half either Sony NEX-7 (24MP) or Sony a7r iii (40+MP) :-). It takes a while. @michaelrsweet Thanks -- that seems like a reasonable fix. With the error message, it will be (more) possible to find the cause and deal with it. |
It should be easier to diagnose time outs from spooling application to CUPS.
Ran Adobe Lightroom to produce a large print. Due to machine's age, etc., job took a long time (5.5 minutes). CUPS
Timeout
setting at default is 300 seconds. CUPS error log sayswhich gives no hint that there was a timeout.
Doing this on MacOS, I could use
cupsctl
to setLoglevel
to debug, and then I saw the timeout. ChangedTimeout
to better value & things work as expected. As a user, I shouldn't have to go that deep to diagnose things. Log level for timeout message should be changed.The text was updated successfully, but these errors were encountered: