-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ippValidateAttribute: Properly detect strings with an invalid last character #5509
Comments
If the approach in |
Hmm, I'm not keen on those changes. But I can see how a truncated string or one that sortof looks like UTF-8 could cause this. |
michaelrsweet
added a commit
that referenced
this issue
Feb 5, 2019
michaelrsweet
added a commit
that referenced
this issue
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An ISO/IEC 8859-1 / Latin-1 string with an invalid last character whose UTF8 equivalent is a multi-byte sequence is currently not detected correctly in ippValidateAttribute, leading to a _dbus_check_is_valid_utf8 crash in relaxed conformance mode. The multi-byte sequence check in ippValidateAttribute expects that the following bytes exist, and this is not the case here.
To catch this case, I think ippValidateAttribute needs to check whether the string finishes midway in a multi-byte sequence check for IPP_TAG_TEXT* and IPP_TAG_NAME* strings.
The text was updated successfully, but these errors were encountered: