Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirtyCleanInterval ignored in 2.2.5 #5118

Closed
aschweiz opened this issue Sep 21, 2017 · 2 comments
Closed

DirtyCleanInterval ignored in 2.2.5 #5118

aschweiz opened this issue Sep 21, 2017 · 2 comments
Assignees
Milestone

Comments

@aschweiz
Copy link

aschweiz commented Sep 21, 2017

With DirtyCleanInterval set to 2 in cupsd.conf, CUPS 2.2.0 (macOS 10.12.6) used to quickly save the job control file to disk for new print jobs (even if e.g. the printer couldn't be reached).

In CUPS 2.2.5 (macOS 11 GM), the same configuration has no effect. The job control file isn't written.


Seems to be caused by this commit: b393bc2#diff-567c1adc100951412e5ab030ee1c9f1f

cupsArrayCount(Clients) is not zero in my case:
imac-test1:cups root# tail -f /var/log/cups/error_log | grep "Report: clients"
D [21/Sep/2017:13:59:14 +0200] Report: clients=1
D [21/Sep/2017:14:00:14 +0200] Report: clients=4
D [21/Sep/2017:14:01:14 +0200] Report: clients=4
D [21/Sep/2017:14:02:15 +0200] Report: clients=1
D [21/Sep/2017:14:03:16 +0200] Report: clients=5

@michaelrsweet
Copy link
Collaborator

Part of the reason for this change was to avoid blocking IO while clients are active, need to investigate this more...

@michaelrsweet michaelrsweet modified the milestones: CUPS 2.2.x Updates, CUPS 2.3.x Release Oct 12, 2017
michaelrsweet pushed a commit that referenced this issue Nov 8, 2017
…f there

were open client connections (Issue #5118)

(reverted b393bc2)
@michaelrsweet
Copy link
Collaborator

OK, we have fixed the issue of priority inversion (which was causing IO to block unnecessarily) so I have reverted the change...

[master eb2cb9b] The scheduler did not write out dirty configuration and state files if there were open client connections (Issue #5118)

vcunat pushed a commit to NixOS/nixpkgs that referenced this issue Feb 24, 2018
Upstream report: apple/cups#5118

In addition to not saving files, this results in spam messages in the log once per second (Expiring subscriptions...)
which is what led me to discover this bug. The patch was made by hand because the patch from the commit does not apply.
michaelrsweet added a commit that referenced this issue Mar 7, 2018
- Fixed a compile issue when PAM is not available (Issue #5253)
- Documentation fixes (Issue #5252)
- Star Micronics printers need the "unidir" USB quirk rule (Issue #5251)
- The scheduler now supports using temporary print queues for older IPP/1.1 print queues like those shared by CUPS 1.3 and earlier (Issue #5241)
- The `cupsRasterWritePixels` function did not correctly swap bytes for some formats (Issue #5225)
- Added a USB quirk rule for Canon MP280 series printers (Issue #5221)
- The `ppdInstallableConflict` tested too many constraints (Issue #5213)
- More fixes for printing to old CUPS servers (Issue #5211)
- The `cupsCopyDest` function now correctly copies the `is_default` value (Issue #5208)
- The scheduler did not work with older versions of uClibc (Issue #5188)
- The scheduler now substitutes default values for invalid job attributes when running in "relaxed conformance" mode (Issue #5186)
- Fixed PAM module detection and added support for the common PAM definitions (Issue #5185)
- Fixed a journald support bug in the scheduler (Issue #5181)
- The cups-driverd program incorrectly stopped scanning PPDs as soon as a loop was seen (Issue #5170)
- Fixed group validation on OpenBSD (Issue #5166)
- Fixed the `ippserver` sample code when threading is disabled or unavailable (Issue #5154)
- The `cupsEnumDests` function did not include options from the lpoptions files (Issue #5144)
- The `SSLOptions` directive now supports `MinTLS` and `MaxTLS` options to control the minimum and maximum TLS versions that will be allowed, respectively (Issue #5119)
- The scheduler did not write out dirty configuration and state files if there were open client connections (Issue #5118)
- The `lpadmin` command now provides a better error message when an unsupported System V interface script is used (Issue #5111)
- The `lp` and `lpr` commands now provide better error messages when the default printer cannot be found (Issue #5096)
- No longer support backslash, question mark, or quotes in printer names (Issue #4966)
- The CUPS library now supports the latest HTTP Digest authentication specification including support for SHA-256 (Issue #4862)
- The `lpstat` command now reports when new jobs are being held (Issue #4761)
- The `lpoptions` command incorrectly saved default options (Issue #4717)
- The `ppdLocalizeIPPReason` function incorrectly returned a localized version of "none" (rdar:https://36566269)
- TLS connections now properly timeout (rdar:https://34938533)
- The IPP backend did not properly detect failed PDF prints (rdar:https://34055474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants