NanoHTTPD server + basic espresso call #1
Conversation
| @@ -0,0 +1,94 @@ | |||
| package io.appium.espressoserver; | |||
There was a problem hiding this comment.
it might be a good idea to add license header to each .java file
android-server-app/app/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| /build | |||
There was a problem hiding this comment.
it might be nice to just have one top-level .gitignore file
There was a problem hiding this comment.
Yeah, we can move it over. This was built by default.
| <manifest xmlns:android="https://schemas.android.com/apk/res/android" | ||
| package="io.appium.espressoserver"> | ||
|
|
||
| <application android:allowBackup="true" android:icon="@mipmap/ic_launcher" |
There was a problem hiding this comment.
do we actually have to include icons?
There was a problem hiding this comment.
No I'll get rid of them.
| @@ -0,0 +1,17 @@ | |||
| package io.appium.espressoserver; | |||
There was a problem hiding this comment.
do we need this file? is this in anticipation of writing unit tests?
There was a problem hiding this comment.
This is generated by default. I think we should leave it there in the event that we want to write unit tests and this is there as a stub.
android-server-app/build.gradle
Outdated
| jcenter() | ||
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:3.0.0-alpha1' |
There was a problem hiding this comment.
should we be using an alpha version of gradle?
| @LargeTest | ||
| public class ExampleInstrumentedTest { | ||
|
|
||
| public class AppiumResponse { |
There was a problem hiding this comment.
why are we putting classes in classes?
There was a problem hiding this comment.
It's just a PoC for now. I'll be moving everything out afterwards.
| * the {@link ActivityTestRule#getActivity()} method. | ||
| */ | ||
| @Rule | ||
| public ActivityTestRule<MainActivity> mActivityRule = new ActivityTestRule<>( |
There was a problem hiding this comment.
this will be deleted and updated with @imurchie's strategy but fine for now
| MainActivity.class); | ||
|
|
||
| @Test | ||
| public void changeText_newActivity() throws InterruptedException, IOException { |
There was a problem hiding this comment.
should probably call this something else more descriptive like startEspressoServer
|
Or just |
Yes this works too. However I wouldn't want people to get confused since there will be two servers in this project: the node+appium proxy server, then the server running in the espresso context. Just |
Reasonable enough. I'm down with |
|
I'm just assuming we need to commit the gradle-wrapper jar because it was part of the original project and wasn't included in the default .gitignore |
534a06f
to
5f0a8cf
Compare
No description provided.