Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): add type name to UndefinedField error message #577

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

goto-bus-stop
Copy link
Member

This adds a bit more context to the "main" error message for
UndefinedField diagnostics. It was already there in the pretty-printed
version but for use cases like an HTTP backend, it's nice to have as
much context as possible in the main message, so it can just dump that
as a JSON string.

This adds a bit more context to the "main" error message for
UndefinedField diagnostics. It was already there in the pretty-printed
version but for use cases like an HTTP backend, it's nice to have as
much context as possible in the main message, so it can just dump that
as a JSON string.
@goto-bus-stop goto-bus-stop requested a review from lrlna as a code owner June 5, 2023 08:15
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goto-bus-stop goto-bus-stop merged commit 32b617d into main Jun 5, 2023
@goto-bus-stop goto-bus-stop deleted the field-on-type-diagnostic branch June 5, 2023 10:35
@lrlna lrlna added this to the 06/2023 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants