Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify fuzzing targets #157

Closed
wants to merge 1 commit into from
Closed

Conversation

MidasLamb
Copy link
Contributor

By passing &str, rather than [u8], the output is also nicer (i.e.

Output of  `std::fmt::Debug`:

        "\u{0}\u{0}\"\"\u{5}{ca*a,r#")

By passing &str, rather than [u8], the output is also nicer (i.e.
```bash
`std::fmt::Debug`:

        "\u{0}\u{0}\"\"\u{5}{ca*a,r#")
```
@apollo-cla
Copy link

@MidasLamb: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@bnjjj
Copy link
Contributor

bnjjj commented Feb 7, 2022

hi @MidasLamb Thanks for your contribution, unfortunately this code is already deprecated as I'm working on it on this branch https://github.com/apollographql/apollo-rs/tree/bnj/feat_apollo_smith feel free to take a look if you want, but it's still in progress.

@lrlna lrlna closed this Feb 7, 2022
@MidasLamb
Copy link
Contributor Author

@bnjjj , I just checked out that branch, seems very promising! But can I suggest that maybe instead of replacing the current one with input coming straight from the fuzzer, the generate_valid_document becomes another fuzz target?
I think the value from the current one is that there is almost no presumption about what the input is, while if you start generating documents, you start to embed some sort of knowledge in there, which might cause you to never generate certain inputs which cause problems.

@bnjjj
Copy link
Contributor

bnjjj commented Feb 8, 2022

Thanks @MidasLamb for your help. Will consider it in the future but for now we're very focus on our roadmap to release what we need for apollo-router and rover. Will let you know when we are considering external contributions. Have a nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants