Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuzz:parser invalid input values #810

Closed
BrynCooke opened this issue Jan 22, 2024 · 0 comments · Fixed by #811
Closed

fuzz:parser invalid input values #810

BrynCooke opened this issue Jan 22, 2024 · 0 comments · Fixed by #811
Assignees
@BrynCooke
Labels
apollo-smith bug Something isn't working

Comments

@BrynCooke
Copy link
Contributor

When executing cargo fuzz run parser documents are created with input values with variables e.g.

interface s {
  U0(s0: ID = $FQAAAAAAAAAAAAAAAAAAAAAAA, A1: A0, A2: A0): A0
  M1: A0
}

This is invalid as per https://spec.graphql.org/October2021/#Value
Variables should not be used in a const context. This means that within a graphql schema variables should not be used, only within an operation.
@BrynCooke BrynCooke added bug Something isn't working apollo-smith labels Jan 22, 2024
@BrynCooke BrynCooke self-assigned this Jan 22, 2024
BrynCooke added a commit that referenced this issue Jan 22, 2024
@BrynCooke
Add constness to input value generation.
178cb0d 
As per the spec: https://spec.graphql.org/October2021/#Value
Values should not be variables in a const context.
The TLDR of this is that within schema definitions variables should bot be used on arguments.
Within operations variables can should be used.

Fixes #810
BrynCooke added a commit that referenced this issue Jan 22, 2024
@BrynCooke
Add constness to input value generation.
23bf9b0 
As per the spec: https://spec.graphql.org/October2021/#Value
Values should not be variables in a const context.
The TLDR of this is that within schema definitions variables should bot be used on arguments.
Within operations variables can should be used.

Fixes #810
@BrynCooke BrynCooke mentioned this issue Jan 22, 2024
Merged
BrynCooke added a commit that referenced this issue Jan 22, 2024
@BrynCooke
Add constness to input value generation (#811)
32dc139 
* Add constness to input value generation.

As per the spec: https://spec.graphql.org/October2021/#Value
Values should not be variables in a const context.
The TLDR of this is that within schema definitions variables should bot be used on arguments.
Within operations variables can should be used.

Fixes #810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrynCooke BrynCooke

Labels
apollo-smith bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add constness to input value generation apollographql/apollo-rs
1 participant
@BrynCooke