Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding patch for field core module #1058

Open
wants to merge 13 commits into
base: 3.x
Choose a base branch
from

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #1057

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.37%. Comparing base (e22b578) to head (e25c281).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x    #1058   +/-   ##
=========================================
  Coverage     44.37%   44.37%           
  Complexity     3041     3041           
=========================================
  Files           342      342           
  Lines         11111    11111           
=========================================
  Hits           4931     4931           
  Misses         6180     6180           

@mxr576
Copy link
Contributor

mxr576 commented May 28, 2024

Just as in previous occasion, I am really uncertain if this module should install a patch on Drupal core. Applying a patch on a project can fail for many reasons,like "incorrect" Drupal core version or conflicting patches applied already.

Probably it would be enough documenting this as a known issue and suggesting downstream projects to install the latest patch from the D.o issue if they are affected.

@kedarkhaire
Copy link
Collaborator Author

Hi @mxr576 Yes noted your point, we will be mentioning the changes on documentation only. Also this patch will be applied on devportal composer project only for D10.2 i.e. on 10x branch.

@kedarkhaire kedarkhaire changed the title Adding patch for field drupal core module Adding patch for field core module Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WSOD while creating select list field on Developer Apps & Team Apps
2 participants