Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YETUS-1145. add rstcheck #267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

YETUS-1145. add rstcheck #267

wants to merge 1 commit into from

Conversation

aw-was-here
Copy link
Contributor

No description provided.

ndimiduk
ndimiduk reviewed May 2, 2022
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the i18n change come via a separate JIRA? Seems like it touches more code than was expected from the rstcheck feature.

ndimiduk
ndimiduk requested changes May 2, 2022
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ant, cmake, gradel, maven, make all follow the --foo-cmd pattern.

precommit/src/main/shell/plugins.d/rstcheck.sh

for i in "$@"; do
case ${i} in
--rstcheck=*)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be --rstcheck-cmd, so as to be consistent with our other plugins that permit specifying the executable path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precommit is wildly inconsistent here. Some use --foo-cmd= and some use --foo=. There should really be a follow-on JIRA to make these consistent.

@aw-was-here
Copy link
Contributor Author

Should the i18n change come via a separate JIRA? Seems like it touches more code than was expected from the rstcheck feature.

I wanted to cover rstcheck support for i18n while I was still thinking about it. Now that the i18n PR is merged, I've rebased on top of the current main in order to pull it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aw-was-here @ndimiduk