-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for enabling MyPy in CI #8302
Conversation
Thanks @mikepapadim ! Can we merge the mypy check to the ci lint stage? This is mainly to simplify the pipeline. We can also push the items to https://github.com/apache/tvm/blob/main/tests/scripts/task_lint.sh |
Sure, I will revert the changes and keep it in the lint stage. |
3deaafb
to
52962b3
Compare
52962b3
to
e957f17
Compare
9d2139c
to
66b303a
Compare
@mikepapadim Thanks! It's really great to have type check for python codes. While seems the CI failed on mypy but it didn't throw any error? In my understanding, mypy requires python files to specifie data type explicitly for function parameters and return values, but we have not yet add the missing data type to these two dirs in this PR? |
@jcf94 you are right. This PR does not fix the missing data types, it is only enables MyPy. At this point error logging is disabled ( by setting
These two dirs are serving as placeholders atm. Ideally, this PR adds the basic functionality. |
@mikepapadim Thanks, that make sense to me. p.s. I just find a:
error in the CI log, does that need to be solved? |
|
It's better to specify all linting/format checking tool versions (i.e., pylint, mypy, black, clang-format) to make sure the results are consistent. |
@junrushao1994 we can followup with a PR |
@junrushao1994 #8367 Please have a look in this one |
This PR adds initial support for
MyPy
in the Jenkins pipeline.At this point, it checks only
python/tvm/runtime
andpython/tvm/auto_scheduler
.MyPy
in linting stage,Makefile
for$ make mypy
.@jroesch @jwfromm