Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fixed Docstring usage example in tvm.ir.make_node #16610

Merged
merged 2 commits into from
Feb 20, 2024
Merged

[Doc] Fixed Docstring usage example in tvm.ir.make_node #16610

merged 2 commits into from
Feb 20, 2024

Conversation

felix-ro
Copy link
Contributor

The provided usage example for tvm.ir.make_node has become outdated. Creating an IR node of type IntImm requires the field span.

Compare: make_node Unit Test

quic-sanirudh
quic-sanirudh approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@quic-sanirudh quic-sanirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there a reason for the tvm.runtime.String addition. the FFI call should automatically handle if I'm not mistaken.

@felix-ro
Copy link
Contributor Author

LGTM, but is there a reason for the tvm.runtime.String addition. the FFI call should automatically handle if I'm not mistaken.

I just checked the FFI call, and it is handled there. I have updated the pr accordingly.

@tqchen tqchen merged commit e5bfb02 into apache:main Feb 20, 2024
18 checks passed
@ysh329 ysh329 mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quic-sanirudh quic-sanirudh quic-sanirudh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felix-ro @quic-sanirudh @tqchen