Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Upgrade oneflow to v0.8.0 #15862

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

lhutton1
Copy link
Contributor

@lhutton1 lhutton1 commented Oct 3, 2023

The PR #15819 installed oneflow from PyPi in an attempt to unblock CI failing on the gpu docker image build. However, it seems to be a placeholder package. This PR upgrades the version of oneflow to v0.8.0 in a second attempt to unblock CI.

@lhutton1
Copy link
Contributor Author

lhutton1 commented Oct 3, 2023

Apologies, when locally testing #15819 it appears I was testing with the old package (pip install -f https://release.oneflow.info oneflow==0.7.0+cpu) as opposed to (pip install oneflow==0.7.0) leading to the wrong conclusion that the patch worked. This mistake wasn't noticed until #15836

The PR apache#15819 installed oneflow from PyPi in an attempt to unblock CI
failing on the gpu docker image build. However, it seems to be a
placeholder package. This PR upgrades the version of oneflow to v0.8.0
in a second attempt to unblock CI.

Change-Id: I92bcc6aee79dfcbeba7c13cf0b6d91104be16f5c
@lhutton1
Copy link
Contributor Author

lhutton1 commented Oct 4, 2023

cc @ashutosh-arm @leandron

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lhutton1

@leandron leandron merged commit 7a1f7d0 into apache:main Oct 4, 2023
18 checks passed
@lhutton1 lhutton1 deleted the upgrade-oneflow-0.8.0 branch October 4, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants