Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for archetype-descriptors / maven-compiler-plugin version consistency #5

Merged

Conversation

JCgH4164838Gh792C124B5
Copy link
Contributor

Minor changes:

  • Make all archetype-descriptor "name" attributes match the archetype they belong to.
  • Make all maven-compiler-plugin versions 3.6.2.

- Make all archetype-descriptor "name" attributes match the archetype
  they belong to.
- Make all maven-compiler-plugin versions 3.6.2.
@JCgH4164838Gh792C124B5
Copy link
Contributor Author

Hello @lukaszlenart .

I'm not familiar enough with Maven Archetypes to be certain, but I think the archetype-descriptor entries are intended to match the archetype they belong to ?

If the preceding assumption is incorrect, then please just ignore this PR. 😄

Copy link
Member

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukaszlenart lukaszlenart merged commit 9f78b27 into apache:master May 11, 2020
@JCgH4164838Gh792C124B5 JCgH4164838Gh792C124B5 deleted the FixMetadataNameMismatches branch May 16, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants