This repository has been archived by the owner on May 12, 2021. It is now read-only.
Google compute engine load balancing support #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ELoadBalancer.java file
…ELoadBalancer.java file
…ELoadBalancer.java file
…ELoadBalancer.java file
…he position of some log messages
| return "https://www.googleapis.com/compute/v1/projects/" + PROJECT_ID + | ||
| "/zones/" + getZoneNameFromInstanceId(instanceId) + "/instances/" + getInstanceNameFromInstanceId(instanceId); | ||
| } | ||
|
|
There was a problem hiding this comment.
Shall we read the google api url from the configuration? Also we can use constants for other hard-corded values.
fe0622a
to
4862b29
Compare
|
I have changed the logic for health check creation. So health checks are created using the port map configuration related to the application instead of using the user provided port. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.