[SPARK-36681][CORE][TEST] Enable SnappyCodec test in FileSuite #35784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
approved these changes
Mar 9, 2022
dongjoon-hyun
approved these changes
Mar 9, 2022
|
Thanks @martin-g @dongjoon-hyun |
|
Merging to master. |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
Mar 10, 2022
### What changes were proposed in this pull request? This patch enables `SnappyCodec` test in `FileSuite` as snappy-java relocation issue was fixed in Hadoop 3.3.2 that Spark is using now. ### Why are the changes needed? Enabling test case. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Updated test. Closes apache#35784 from viirya/SPARK-36681. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
|
Hm, actually this test seems flaky: https://github.com/apache/spark/runs/5687379822 |
|
Hmm, |
HyukjinKwon
added a commit
that referenced
this pull request
Apr 11, 2022
…ibrary is available in low Hadoop versions ### What changes were proposed in this pull request? This PR is a minor followup to only test when Snappy native library is available in low Hadoop versions. From Hadoop 3.3.1 with `HADOOP-17125`, the tests should pass but it fails in lower versions of Hadoop when Snappy native library is unavailable (see also #35784 (comment)). ### Why are the changes needed? To make the tests robust. ### Does this PR introduce _any_ user-facing change? Nope, this is test-only. ### How was this patch tested? Should monitor CI Closes #36136 from HyukjinKwon/SPARK-36681. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit bf19a5e) Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
added a commit
that referenced
this pull request
Apr 11, 2022
…ibrary is available in low Hadoop versions ### What changes were proposed in this pull request? This PR is a minor followup to only test when Snappy native library is available in low Hadoop versions. From Hadoop 3.3.1 with `HADOOP-17125`, the tests should pass but it fails in lower versions of Hadoop when Snappy native library is unavailable (see also #35784 (comment)). ### Why are the changes needed? To make the tests robust. ### Does this PR introduce _any_ user-facing change? Nope, this is test-only. ### How was this patch tested? Should monitor CI Closes #36136 from HyukjinKwon/SPARK-36681. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch enables
SnappyCodectest inFileSuiteas snappy-java relocation issue was fixed in Hadoop 3.3.2 that Spark is using now.Why are the changes needed?
Enabling test case.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Updated test.