[SPARK-37533][SQL][FOLLOWUP] try_element_at should throw an error on 0 array index #34833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
commented
Dec 8, 2021
| case class TryElementAt(left: Expression, right: Expression, child: Expression) | ||
| extends RuntimeReplaceable { | ||
| def this(left: Expression, right: Expression) = | ||
| this(left, right, TryEval(ElementAt(left, right, failOnError = false))) |
There was a problem hiding this comment.
we don't need TryEval any more. Moving the class next to ElementAt
gengliangwang
commented
Dec 8, 2021
| @@ -1996,9 +1996,10 @@ case class ArrayPosition(left: Expression, right: Expression) | |||
| */ | |||
| @ExpressionDescription( | |||
| usage = """ | |||
| _FUNC_(array, index) - Returns element of array at given (1-based) index. If index < 0, | |||
There was a problem hiding this comment.
Let's mention that 0 index will throw an error in the function description.
cloud-fan
approved these changes
Dec 8, 2021
HyukjinKwon
approved these changes
Dec 8, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #146005 has finished for PR 34833 at commit
|
|
Merged to master. |
gengliangwang
referenced
this pull request
Dec 8, 2021
### What changes were proposed in this pull request? Add New SQL functions `try_element_at`, which is identical to the `element_at` except that it returns null if error occurs ### Why are the changes needed? After some data science on real world SQL queries, we found that some users are using the following queries ``` select ... where mapCol.key is not null select ... where arrayCol[index] is not null ``` ### Does this PR introduce _any_ user-facing change? Yes, an alternative function `try_element_at` which will return null on array index out of bound or map key doesn't exist under ANSI mode. ### How was this patch tested? Unit tests Closes #34796 from gengliangwang/try_element_at. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the new function
try_element_atto throw an error on 0 array indexWhy are the changes needed?
As @srielau points out in f705e52#commitcomment-61541454, array index can't be 0 in
element_at/try_element_atand we should throw an error to remind users.Does this PR introduce any user-facing change?
No, the new function is not released yet.
How was this patch tested?
Unit tests