[SPARK-37468][SQL] Support ANSI intervals and TimestampNTZ for UnionEstimation #34716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #145646 has finished for PR 34716 at commit
|
MaxGekk
reviewed
Nov 29, 2021
...main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/UnionEstimation.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/UnionEstimation.scala
Outdated
Show resolved
Hide resolved
…s/logical/statsEstimation/UnionEstimation.scala Co-authored-by: Maxim Gekk <[email protected]>
…s/logical/statsEstimation/UnionEstimation.scala Co-authored-by: Maxim Gekk <[email protected]>
MaxGekk
approved these changes
Nov 29, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
+1, LGTM. Merging to master. |
|
Test build #145724 has finished for PR 34716 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to support ANSI intervals and TimestampNTZ for
UnionEstimation.Currently,
UnionEstimationdoesn't support ANSI intervals and TimestampNTZ. But I think it can support those types because their underlying types are integer or long, whichUnionEstimationcan compute stats for.Why are the changes needed?
To make CBO better.
Does this PR introduce any user-facing change?
No. Not interferes with the current behavior.
How was this patch tested?
Modified
UnionEstimationSuite.