Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-35413][INFRA] Use the SHA of the latest commit when checking out databricks/tpcds-kit #32561

Closed
wants to merge 3 commits into from
Closed

[SPARK-35413][INFRA] Use the SHA of the latest commit when checking out databricks/tpcds-kit #32561

wants to merge 3 commits into from

Conversation

maropu
Copy link
Member

@maropu maropu commented May 16, 2021

What changes were proposed in this pull request?

This PR proposes to use the SHA of the latest commit (2a5078a782192ddb6efbcead8de9973d6ab4f069) when checking out databricks/tpcds-kit. This can prevent the test workflow from breaking accidentally if the repository changes drastically.

Why are the changes needed?

For better test workflow.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

GA passed.

@maropu
Copy link
Member Author

maropu commented May 16, 2021

cc: @HyukjinKwon @dongjoon-hyun

@SparkQA
Copy link

SparkQA commented May 16, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43107/

@SparkQA
Copy link

SparkQA commented May 16, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43107/

@SparkQA
Copy link

SparkQA commented May 16, 2021

Test build #138586 has finished for PR 32561 at commit 758000c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen reviewed May 16, 2021
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a fine idea. How often does this change? do we risk not picking up important changes? but yeah we should pin this.

@kiszk
Copy link
Member

kiszk commented May 16, 2021

Good idea to prevent unexpected changes in the future while we may have a risk not to pick up the important change.

dongjoon-hyun
dongjoon-hyun approved these changes May 16, 2021
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@github-actions github-actions bot added the INFRA label May 16, 2021
@maropu
Copy link
Member Author

maropu commented May 16, 2021

Thank you, @srowen @kiszk @dongjoon-hyun I re-triggered a job to generate the data for checking if it works correctly before merging this.

@maropu
Copy link
Member Author

maropu commented May 16, 2021

Seems like a fine idea. How often does this change? do we risk not picking up important changes? but yeah we should pin this.

Yea, I think the change rarely happens, but as its better to avoid unexpected test failures as much as possible.

@SparkQA
Copy link

SparkQA commented May 17, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43115/

@SparkQA
Copy link

SparkQA commented May 17, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43115/

@maropu maropu closed this in 2390b9d May 17, 2021
maropu added a commit that referenced this pull request May 17, 2021
@maropu
[SPARK-35413][INFRA] Use the SHA of the latest commit when checking o…
f9a396c 
…ut databricks/tpcds-kit

### What changes were proposed in this pull request?

This PR proposes to use the SHA of the latest commit ([2a5078a782192ddb6efbcead8de9973d6ab4f069](databricks/tpcds-kit@2a5078a)) when checking out `databricks/tpcds-kit`. This can prevent the test workflow from breaking accidentally if the repository changes drastically.

### Why are the changes needed?

For better test workflow.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

GA passed.

Closes #32561 from maropu/UseRefInCheckout.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
(cherry picked from commit 2390b9d)
Signed-off-by: Takeshi Yamamuro <[email protected]>
maropu added a commit that referenced this pull request May 17, 2021
@maropu
[SPARK-35413][INFRA] Use the SHA of the latest commit when checking o…
8ebc1d3 
…ut databricks/tpcds-kit

### What changes were proposed in this pull request?

This PR proposes to use the SHA of the latest commit ([2a5078a782192ddb6efbcead8de9973d6ab4f069](databricks/tpcds-kit@2a5078a)) when checking out `databricks/tpcds-kit`. This can prevent the test workflow from breaking accidentally if the repository changes drastically.

### Why are the changes needed?

For better test workflow.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

GA passed.

Closes #32561 from maropu/UseRefInCheckout.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
(cherry picked from commit 2390b9d)
Signed-off-by: Takeshi Yamamuro <[email protected]>
@maropu
Copy link
Member Author

maropu commented May 17, 2021

okay, I've checked if it works correctly. Merged to master/3.0/3.1.

@maropu
Copy link
Member Author

maropu commented May 17, 2021

Thank you, @HyukjinKwon , too.

@SparkQA
Copy link

SparkQA commented May 17, 2021

Test build #138594 has finished for PR 32561 at commit 9357a49.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu maropu deleted the UseRefInCheckout branch June 23, 2021 13:24
flyrain pushed a commit to flyrain/spark that referenced this pull request Sep 21, 2021
@maropu @sunchao
[SPARK-35413][INFRA] Use the SHA of the latest commit when checking o…
93984aa 
…ut databricks/tpcds-kit

### What changes were proposed in this pull request?

This PR proposes to use the SHA of the latest commit ([2a5078a782192ddb6efbcead8de9973d6ab4f069](databricks/tpcds-kit@2a5078a)) when checking out `databricks/tpcds-kit`. This can prevent the test workflow from breaking accidentally if the repository changes drastically.

### Why are the changes needed?

For better test workflow.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

GA passed.

Closes apache#32561 from maropu/UseRefInCheckout.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
(cherry picked from commit 2390b9d)
Signed-off-by: Takeshi Yamamuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen left review comments

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
INFRA
Projects
None yet
Milestone
No milestone
6 participants
@maropu @SparkQA @kiszk @srowen @HyukjinKwon @dongjoon-hyun