Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java.lang.ClassFormatError: Duplicate interface name "org/apache/skywalking/apm/agent/core/plugin/interceptor/enhance/EnhancedInstance" #6173

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

zifeihan
Copy link
Member

Fix Java.lang.ClassFormatError: Duplicate interface name "org/apache/skywalking/apm/agent/core/plugin/interceptor/enhance/EnhancedInstance"

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

The cause and fix of the problem are as follows, #6172

…skywalking/apm/agent/core/plugin/interceptor/enhance/EnhancedInstance"
@wu-sheng wu-sheng added this to the 8.4.0 milestone Jan 11, 2021
@wu-sheng wu-sheng self-requested a review January 11, 2021 12:14
@wu-sheng wu-sheng added agent Language agent related. bug Something isn't working and you are sure it's a bug! core feature Core and important feature. Sometimes, break backwards compatibility. labels Jan 11, 2021
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #6173 (0267d6d) into master (3e4d550) will decrease coverage by 19.38%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #6173       +/-   ##
=============================================
- Coverage     51.23%   31.85%   -19.39%     
+ Complexity     3526      740     -2786     
=============================================
  Files          1700     1627       -73     
  Lines         35972    33975     -1997     
  Branches       3975     4236      +261     
=============================================
- Hits          18431    10822     -7609     
- Misses        16594    22237     +5643     
+ Partials        947      916       -31     
Impacted Files Coverage Δ Complexity Δ
.../interceptor/enhance/ClassEnhancePluginDefine.java 47.67% <66.66%> (-0.57%) 15.00 <0.00> (ø)
...he/skywalking/oal/rt/output/DispatcherContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...skywalking/oal/rt/output/AllDispatcherContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ache/skywalking/oap/server/core/source/Source.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...che/skywalking/oap/server/core/source/Service.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...che/skywalking/oap/server/core/source/SideCar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...he/skywalking/oap/server/core/source/Endpoint.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...he/skywalking/oap/server/core/source/GCPhrase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...e/skywalking/oap/server/core/CoreModuleConfig.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
.../skywalking/oap/server/core/alarm/AlarmModule.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
... and 647 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4d550...0267d6d. Read the comment docs.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for the all plugin tests to verify.

@wu-sheng wu-sheng merged commit 4877a22 into apache:master Jan 11, 2021
@wu-sheng wu-sheng mentioned this pull request Jan 12, 2021
2 tasks
@zifeihan zifeihan deleted the agent_fix branch January 12, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. bug Something isn't working and you are sure it's a bug! core feature Core and important feature. Sometimes, break backwards compatibility.
Projects
None yet
2 participants