Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector-jdbc][bugfix] fix mysql create table comment special string bug #6998

Merged

Conversation

chl-wxp
Copy link
Contributor

@chl-wxp chl-wxp commented Jun 17, 2024

Check list

  • fix mysql create table comment special string bug

@chl-wxp chl-wxp changed the title [bugfix][connector-jdbc] fix mysql create table comment special string bug [connector-jdbc][bugfix] fix mysql create table comment special string bug Jun 17, 2024
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

columnSqls.add("COMMENT '" + column.getComment() + "'");
columnSqls.add(
"COMMENT '"
+ column.getComment().replace("'", "''").replace("\\", "\\\\")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有别的字符需要处理吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two special sensitive characters are currently discovered

@EricJoy2048 EricJoy2048 merged commit 904e9cf into apache:dev Jun 17, 2024
5 checks passed
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants