Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8463] Some statistical items should also be deleted to prevent memory leakage when a topic or group is deleted #8464

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Jul 29, 2024

Which Issue(s) This PR Fixes

Fixes #8463

Brief Description

Some statistical items should also be deleted to prevent memory leakage when a topic or group is deleted

How Did You Test This Change?

…mory leakage when a topic or group is deleted
@RongtongJin RongtongJin changed the title [ISSUE #8463] Some important statistical items should also be deleted to prevent memory leakage when a topic or group is deleted [ISSUE #8463] Some statistical items should also be deleted to prevent memory leakage when a topic or group is deleted Jul 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.87%. Comparing base (263f0fb) to head (a1388e9).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8464      +/-   ##
=============================================
- Coverage      45.91%   45.87%   -0.04%     
- Complexity     11101    11114      +13     
=============================================
  Files           1274     1274              
  Lines          89002    89005       +3     
  Branches       11441    11443       +2     
=============================================
- Hits           40863    40832      -31     
- Misses         43031    43063      +32     
- Partials        5108     5110       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fuyou001
fuyou001 previously approved these changes Jul 30, 2024
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cserwen
cserwen previously approved these changes Jul 30, 2024
Copy link
Contributor

@GenerousMan GenerousMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tsunghanjacktsai tsunghanjacktsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Focus-rth Focus-rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin dismissed stale reviews from cserwen and fuyou001 via a1388e9 July 30, 2024 06:25
@ni-ze
Copy link
Contributor

ni-ze commented Aug 1, 2024

LGTM~

@ShannonDing ShannonDing merged commit 3696be0 into develop Aug 1, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Some statistical items should also be deleted to prevent memory leakage when a topic or group is deleted
10 participants