Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Timing message metric will be inaccurate due to incorrect deletion behavior #7979

Closed
3 tasks done
GenerousMan opened this issue Mar 28, 2024 · 1 comment · Fixed by #7980
Closed
3 tasks done
Assignees

Comments

@GenerousMan
Copy link
Contributor

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Ubuntu

RocketMQ version

5.2.0

JDK Version

No response

Describe the Bug

When a timing message is deleted, it is implemented by sending a delete message. Since the timerlog of the timing message is actually an index, it cannot be verified in real time whether the deletion is valid, so -1 will be directly set to the metric when received.
This will lead to a problem: if the deletion behavior is invalid, the -1 operation will not be compensated, and may even cause the metric to become a negative number - which is unacceptable.

Steps to Reproduce

according to the description of the bug.

What Did You Expect to See?

the abnormal -1 should be compensated.

What Did You See Instead?

-1 will always be there.

Additional Context

No response

@3424672656
Copy link
Contributor

I am interested in this problem, please assign it to me

@HScarb HScarb linked a pull request Apr 1, 2024 that will close this issue
RongtongJin pushed a commit that referenced this issue Apr 1, 2024
* fix metric in TimerWheel

* fix metric in TimerWheel

* fix message metric in TimerWheel

* fix message metric in TimerWheel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants