[ISSUE #553] Feat: Integrate RocketMQ 5.0 client with Spring #554

1294566108 · 2023-04-23T10:17:36Z

What is the purpose of the change

RocketMQ recently released the 5.0 client SDK. At present, we have integrated the 4.x version of SDK to Spring, so we also need to integrate the 5.0 SDK client to Spring to better and faster use the new version of the client's Spring integration.

Brief changelog

Add New annotations support the producers and consumers of the 5.0 SDK client
Provides compatibility methods for the Spring Messaging interface
Add message container template for message sending and receiving

aaron-ai · 2023-05-08T03:27:47Z

@1294566108 Fantastic work!

Meanwhile, could you fix the CI issue?

1294566108 · 2023-05-08T05:06:39Z

Okay, I just uploaded the code again. It seems that the local compilation seems to have passed

aaron-ai

Could you provide more documentation or code examples to help us understand how to utilize the 5.x client?

1294566108 · 2023-05-09T11:57:14Z

Okay, I will prepare a User Guide and Readme documentation first

RongtongJin · 2023-05-08T03:40:23Z

...t-producer-demo/src/main/java/org/apache/rocketmq/samples/springboot/domain/UserMessage.java

+/**
+ * @author Akai
+ */


Plz remove the author info.

RongtongJin · 2023-05-11T08:15:05Z

rocketmq-client-spring-boot-samples/LICENSE

It seems that this file is unnecessary.

RongtongJin · 2023-05-11T08:46:28Z

pom.xml

+ <module>rocketmq-client-spring-boot</module>
+ <module>rocketmq-client-spring-boot-parent</module>
+ <module>rocketmq-client-spring-boot-starter</module>


It seems that the name of the module cannot be well distinguished from the original remoting client. Maybe rename o rocketmq-grpc-client-spring-boot?

Is there a possibility that we don't emphasize gRPC, since the artifact id of 5.x SDK doesn't contain the keyword "gRPC" either?

Does this UserGuide need to be presented to users like a wiki document? If so, it is necessary to consider writing a bilingual version of the document like this.

Does this UserGuide need to be presented to users like a wiki document? If so, it is necessary to consider writing a bilingual version of the document like this.

Yes, I think we also need a user guide.

Is there a possibility that we don't emphasize gRPC, since the artifact id of 5.x SDK doesn't contain the keyword "gRPC" either?

Or rocketmq-v5-client-spring-boot?

@RongtongJin I agree with you.

…g method

1294566108 · 2023-05-26T17:52:57Z

May 27, 2023

The recent additions and modifications are as follows：

Add README-CN.md as a User Guide
Add the test code of the ACL authority control module
Modify the asynchronous sending method

RongtongJin · 2023-06-01T06:17:18Z

rocketmq-client-spring-boot-samples/README-CN.md

+
+### 修改application.properties
+
+**rocketmq.producer.topic：**用于给生产者设置topic名称（可选，但建议使用），生产者可以在消息发布之前**预取**topic路由。<br />**demo.rocketmq.normal-topic：**用户自定义消息发送的topic


这里的加粗似乎有点问题。

RongtongJin · 2023-06-01T06:20:43Z

rocketmq-client-spring-boot-samples/README-CN.md

+ void testSendNormalMessage() {
+ SendReceipt sendReceipt = rocketMQClientTemplate.syncSendNormalMessage(normalTopic, new UserMessage()
+ .setId(1).setUserName("name").setUserAge((byte) 3));
+ System.out.printf("normalSend to topic %s sendReceipt=%s %n", normalTopic, sendReceipt);
+
+ sendReceipt = rocketMQClientTemplate.syncSendNormalMessage(normalTopic, "normal message");
+ System.out.printf("normalSend to topic %s sendReceipt=%s %n", normalTopic, sendReceipt);
+
+ sendReceipt = rocketMQClientTemplate.syncSendNormalMessage(normalTopic, "byte message".getBytes(StandardCharsets.UTF_8));
+ System.out.printf("normalSend to topic %s sendReceipt=%s %n", normalTopic, sendReceipt);
+
+ sendReceipt = rocketMQClientTemplate.syncSendNormalMessage(normalTopic, MessageBuilder.
+ withPayload("test message".getBytes()).build());
+ System.out.printf("normalSend to topic %s sendReceipt=%s %n", normalTopic, sendReceipt);
+ }


This part of the example is unnecessary.

RongtongJin · 2023-06-01T06:32:27Z

pom.xml

+ <module>rocketmq-client-spring-boot</module>
+ <module>rocketmq-client-spring-boot-parent</module>
+ <module>rocketmq-client-spring-boot-starter</module>


Is there a possibility that we don't emphasize gRPC, since the artifact id of 5.x SDK doesn't contain the keyword "gRPC" either?

Or rocketmq-v5-client-spring-boot?

1294566108 · 2023-06-02T08:19:10Z

June 2nd

The modifications are as follows：

Remove unnecessary code in README-CN.md
Modifying Errors in README-CN.md File to Avoid Error Reporting
Change the module name from rocketmq-client-spring-boot to rocketmq-v5-client-spring-boot

RongtongJin

@1294566108 Plz pass the license checker workflow

RongtongJin

@1294566108 Plz pass the license checker workflow

1294566108 · 2023-06-24T16:35:37Z

Test the example module and the results are as follows

TEST FOR【rocketmq-v5-client-producer-acl-demo】&【rocketmq-v5-client-consume-acl-demo】successfully：
Includeing accessKey and secretKey
TEST FOR 【rocketmq-v5-client-producer-demo】&【rocketmq-v5-client-consume-demo】successfully：
Including normal、fifo、delay、transaction message

TEST FOR asyc message's sending and receiving successfully
Including Asynchronous sending and receiving

1294566108 · 2023-07-01T09:45:22Z

May I ask if the current testing coverage is sufficient and if there are any additional test cases that need to be added

feat:Integrate RocketMQ 5.0 client with Spring

b116cf1

1294566108 changed the title ~~[ISSU #553] Feat: Integrate RocketMQ 5.0 client with Spring~~ [ISSUE #553] Feat: Integrate RocketMQ 5.0 client with Spring Apr 23, 2023

1294566108 added 2 commits May 5, 2023 09:57

feat:Integrate RocketMQ 5.0 client with Spring

54059fa

feat:Integrate RocketMQ 5.0 client with Spring

14b644b

fix:CI issue

bff897f

aaron-ai reviewed May 9, 2023

View reviewed changes

RongtongJin reviewed May 11, 2023

View reviewed changes

1294566108 added 4 commits May 27, 2023 00:02

fix:remove useless LICENSE and modify the asynchronous message sendin…

e95fd3f

…g method

feat:Add README.md file

85f6e2e

fix:Modify the file name from README.md to README-CN.md

30c66d6

feat:Add test module for ACL permission control

8fe6413

RongtongJin reviewed Jun 1, 2023

View reviewed changes

fix:Remove unnecessary Code in UserGuide And change the module Name

43bd589

RongtongJin reviewed Jun 3, 2023

View reviewed changes

1294566108 added 2 commits June 3, 2023 18:29

fix:fix license checker

e021e05

fix:fix license checker

892076f

RongtongJin mentioned this pull request Jun 7, 2023

can rocketmq-spring support rocketmq5.0 gRPCversion #567

Open

1294566108 added 2 commits June 24, 2023 23:44

fix:Modify and supplement some defects in the testing module code

34be0c0

fix:Modify User Guide

75a9c3f

RongtongJin approved these changes Jul 13, 2023

View reviewed changes

1294566108 requested a review from aaron-ai July 15, 2023 02:33

RongtongJin merged commit b5a43b2 into apache:master Jul 30, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ISSUE #553] Feat: Integrate RocketMQ 5.0 client with Spring #554

[ISSUE #553] Feat: Integrate RocketMQ 5.0 client with Spring #554

1294566108 commented Apr 23, 2023

aaron-ai commented May 8, 2023

1294566108 commented May 8, 2023 •

edited

Loading

aaron-ai left a comment

1294566108 commented May 9, 2023

RongtongJin May 8, 2023

RongtongJin May 11, 2023

RongtongJin May 11, 2023

aaron-ai May 12, 2023

1294566108 May 12, 2023

aaron-ai May 23, 2023

RongtongJin Jun 1, 2023

aaron-ai Jun 1, 2023

1294566108 commented May 26, 2023

RongtongJin Jun 1, 2023

RongtongJin Jun 1, 2023

RongtongJin Jun 1, 2023

1294566108 commented Jun 2, 2023

RongtongJin left a comment

RongtongJin left a comment

1294566108 commented Jun 24, 2023

1294566108 commented Jul 1, 2023


		### 修改application.properties

		rocketmq.producer.topic：用于给生产者设置topic名称（可选，但建议使用），生产者可以在消息发布之前预取topic路由。<br />demo.rocketmq.normal-topic：用户自定义消息发送的topic

[ISSUE #553] Feat: Integrate RocketMQ 5.0 client with Spring #554

[ISSUE #553] Feat: Integrate RocketMQ 5.0 client with Spring #554

Conversation

1294566108 commented Apr 23, 2023

What is the purpose of the change

Brief changelog

aaron-ai commented May 8, 2023

1294566108 commented May 8, 2023 • edited Loading

aaron-ai left a comment

Choose a reason for hiding this comment

1294566108 commented May 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1294566108 commented May 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1294566108 commented Jun 2, 2023

RongtongJin left a comment

Choose a reason for hiding this comment

RongtongJin left a comment

Choose a reason for hiding this comment

1294566108 commented Jun 24, 2023

1294566108 commented Jul 1, 2023

1294566108 commented May 8, 2023 •

edited

Loading