Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RANGER-4920: kms docker - Fix kms service url, volume support for configs #395

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RANGER-4920: kms docker - Fix kms service url, volume support for configs #395

wants to merge 2 commits into from
+806 −1

Conversation

fateh288
Copy link
Contributor

@fateh288 fateh288 commented Sep 24, 2024 •
edited
Loading

What changes were proposed in this pull request?

  1. Fixed service url for kms as key create operation was not succeeding
  2. Introduced volume support for kms docker images so that image re-create is not required for change in configs

How was this patch tested?

  1. Rebuild docker image with new kms bits, created kms docker container
  2. Made some changes to kms-logback.xml (location dev-support/ranger-docker/config/ranger-kms/kms-logback.xml)
  3. Restart kms docker container
  4. updated kms-logback.xml correctly used now for logging (image re-create not required)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneethiraj mneethiraj mneethiraj left review comments

@kumaab kumaab kumaab approved these changes

@spolavarpau1 spolavarpau1 Awaiting requested review from spolavarpau1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fateh288 @mneethiraj @kumaab