Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 6292] [apply-config-from-env.py] Fix the script when settings are already present #6293

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

andresgaragiola
Copy link
Contributor

Fixes #6292

Motivation

As is detailed in the issue, the script is not working properly when the settings are already present in the configuration file.

Modifications

I added an else branch in an existent if that changes the elements of the lines array with existent settings.

Verifying this change

  • [X ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: yes

Documentation

  • Does this pull request introduce a new feature? no

@merlimat merlimat added type/bug The PR fixed a bug or issue reported a bug component/deploy labels Feb 11, 2020
@merlimat merlimat added this to the 2.6.0 milestone Feb 11, 2020
@merlimat merlimat merged commit 7cb61fe into apache:master Feb 11, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The script apply-config-from-env.py doesn't modify existent settings
2 participants