[fix][admin] Fix half deletion when attempt to topic with a incorrect API #23002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtitioned topic with a wrong API
poorbarcode
changed the title
|
/pulsarbot rerun-failure-checks |
Demogorgon314
approved these changes
Jul 5, 2024
nodece
reviewed
Jul 5, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
nodece
reviewed
Jul 5, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Jul 5, 2024
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTopicApiTest.java
Show resolved
Hide resolved
nodece
reviewed
Jul 5, 2024
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTopicApiTest.java
Outdated
Show resolved
Hide resolved
|
Since PIP-344 was not cherry-picked into |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 15, 2024
… API (apache#23002) (cherry picked from commit 1f34497) (cherry picked from commit 0fab9ed)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 15, 2024
… API (apache#23002) (cherry picked from commit 1f34497) (cherry picked from commit 0fab9ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Background
The correct usage of deleting topics:
non-partitioned:pulsar-admin topics delete <topic>partitioned:pulsar-admin topics delete-partitioned-topic <topic>Issue
pulsar-admin topics delete <topic>, you will get a404error:tpxxx is not found. But the schemas have been deleted, and the topic is still there.pulsar-admin topics delete-partitioned-topic <topic>, you will get a404error:tpxxx is not found. But the schemas have been deleted, and the topic is still there.Modifications
a.
tp not found->tpxxx is a partitioned topic, please call delete-partitioned-topic instead.b.
404->409. If the users get a404, they will assume it has been deleted, so change the response code to409.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x