Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pip] PIP-337: SSL Factory Plugin to customize SSL Context and SSL Engine generation #22016

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

Apurva007
Copy link
Contributor

@Apurva007 Apurva007 commented Feb 2, 2024

PIP-337: Create a new SSL Factory Plugin to customize SSL Context and SSL Engine Generation

Motivation

Apache Pulsar's TLS encryption configuration is not pluggable. It only supports file-based certificates. This makes
Pulsar difficult to adopt for organizations that require loading TLS certificates by other mechanisms.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added type/PIP doc-not-needed Your PR changes do not impact docs labels Feb 2, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal. This is very useful. I added some comments about the detailed design.

pip/pip-333.md Outdated Show resolved Hide resolved
pip/pip-333.md Outdated Show resolved Hide resolved
pip/pip-333.md Outdated Show resolved Hide resolved
pip/pip-333.md Outdated Show resolved Hide resolved
pip/pip-333.md Outdated Show resolved Hide resolved
pip/pip-333.md Outdated Show resolved Hide resolved
pip/pip-333.md Outdated Show resolved Hide resolved
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PIP was approved

@merlimat merlimat merged commit 2086cc4 into apache:master Jul 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs PIP type/PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants