Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIP-132] Include message header size when check maxMessageSize for non-batch message on the client side. #14007

Merged
merged 6 commits into from
Mar 8, 2022
Merged

[PIP-132] Include message header size when check maxMessageSize for non-batch message on the client side. #14007

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ebefe6
PIP-132
Jason918 Jan 28, 2022
621b6a9
Fix case: metadata size >= max message size
Jason918 Jan 29, 2022
5451c42
fix style
Jason918 Jan 29, 2022
9b29f00
fix test error in MessageChunkingTest
Jason918 Jan 29, 2022
cc21127
rename checkMaxMessageSize to isMessageSizeExceeded
Jason918 Feb 9, 2022
798f51c
remove static import
Jason918 Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix style
  • Loading branch information
@Jason918
Jason918 committed Jan 29, 2022
commit 5451c4298811a78235455a1012312acdf25b1e5d
5 changes: 3 additions & 2 deletions pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,9 @@ public void sendAsync(Message<?> message, SendCallback callback) {
if (payloadChunkSize <= 0) {
PulsarClientException.InvalidMessageException invalidMessageException =
new PulsarClientException.InvalidMessageException(
format("The producer %s of the topic %s sends a message with %d bytes metadata that exceeds %d bytes",
producerName, topic, msgMetadata.getSerializedSize(), ClientCnx.getMaxMessageSize()));
format("The producer %s of the topic %s sends a message with %d bytes metadata that "
+ "exceeds %d bytes", producerName, topic,
msgMetadata.getSerializedSize(), ClientCnx.getMaxMessageSize()));
completeCallbackAndReleaseSemaphore(uncompressedSize, callback, invalidMessageException);
compressedPayload.release();
return;
Expand Down