Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Fix tools to be consistent with scalastyle #67

Merged
merged 1 commit into from
Mar 7, 2015

Conversation

jtescher
Copy link
Contributor

@jtescher jtescher commented Mar 7, 2015

Most style violations were:

  • multiline if block without braces
  • public methods having explicit type
  • license header

dszeto added a commit that referenced this pull request Mar 7, 2015
Fix tools to be consistent with scalastyle
@dszeto dszeto merged commit a6d8c78 into apache:develop Mar 7, 2015
@dszeto
Copy link
Contributor

dszeto commented Mar 7, 2015

Thanks!

@jtescher
Copy link
Contributor Author

jtescher commented Mar 7, 2015

Any idea why this isn't reflected in the contributor graph? https://github.com/PredictionIO/PredictionIO/graphs/contributors

@dszeto
Copy link
Contributor

dszeto commented Mar 8, 2015

Odd indeed. According to https://help.github.com/articles/i-don-t-see-myself-in-the-repository-contributors-graph/, your name should have shown up.

@dszeto
Copy link
Contributor

dszeto commented Mar 8, 2015

Hey, I just realized your commits are associated with your gmail.com e-mail address. You will need to associate that e-mail address with your GitHub account for you to show up on the contributor graph. Once you've done it, GitHub should update automatically.

@jtescher
Copy link
Contributor Author

jtescher commented Mar 9, 2015

Oh yeah! Thanks fixed it.

@jtescher jtescher deleted the scalastyle-tools branch March 9, 2015 02:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants