add kafka simple consumer buffer and timeout to stream config #3584
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| package com.linkedin.pinot.core.realtime.impl.kafka; | ||
jamesyfshao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
| import com.linkedin.pinot.core.realtime.stream.StreamConfig; | ||
| import com.linkedin.pinot.core.realtime.stream.StreamConfigProperties; | ||
| import org.testng.Assert; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import static org.testng.Assert.*; | ||
| import static com.linkedin.pinot.core.realtime.impl.kafka.KafkaStreamConfigProperties.LowLevelConsumer.*; | ||
|
|
||
| public class KafkaLowLevelStreamConfigTest { | ||
|
|
||
| private KafkaLowLevelStreamConfig getStreamConfig(String topic, String bootstrapHosts, String buffer, String socketTimeout) { | ||
| Map<String, String> streamConfigMap = new HashMap<>(); | ||
| String streamType = "kafka"; | ||
| String consumerType = StreamConfig.ConsumerType.LOWLEVEL.toString(); | ||
| String consumerFactoryClassName = KafkaConsumerFactory.class.getName(); | ||
| String decoderClass = KafkaAvroMessageDecoder.class.getName(); | ||
| streamConfigMap.put(StreamConfigProperties.STREAM_TYPE, streamType); | ||
| streamConfigMap.put( | ||
| StreamConfigProperties.constructStreamProperty(streamType, StreamConfigProperties.STREAM_TOPIC_NAME), topic); | ||
| streamConfigMap.put( | ||
| StreamConfigProperties.constructStreamProperty(streamType, StreamConfigProperties.STREAM_CONSUMER_TYPES), | ||
| consumerType); | ||
| streamConfigMap.put(StreamConfigProperties.constructStreamProperty(streamType, | ||
| StreamConfigProperties.STREAM_CONSUMER_FACTORY_CLASS), consumerFactoryClassName); | ||
| streamConfigMap.put( | ||
| StreamConfigProperties.constructStreamProperty(streamType, StreamConfigProperties.STREAM_DECODER_CLASS), | ||
| decoderClass); | ||
| streamConfigMap.put("stream.kafka.broker.list", bootstrapHosts); | ||
| if (buffer != null) { | ||
| streamConfigMap.put("stream.kafka.buffer.size", buffer); | ||
| } | ||
| if (socketTimeout != null) { | ||
| streamConfigMap.put("stream.kafka.socket.timeout", String.valueOf(socketTimeout)); | ||
| } | ||
| return new KafkaLowLevelStreamConfig(new StreamConfig(streamConfigMap)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetKafkaTopicName() { | ||
| KafkaLowLevelStreamConfig config = getStreamConfig("topic", "", "", ""); | ||
| Assert.assertEquals("topic", config.getKafkaTopicName()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetBootstrapHosts() { | ||
| KafkaLowLevelStreamConfig config = getStreamConfig("topic", "host1", "", ""); | ||
| Assert.assertEquals("host1", config.getBootstrapHosts()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetKafkaBufferSize() { | ||
| // test default | ||
| KafkaLowLevelStreamConfig config = getStreamConfig("topic", "host1", null, ""); | ||
| Assert.assertEquals(KafkaStreamConfigProperties.LowLevelConsumer.KAFKA_BUFFER_SIZE_DEFAULT, config.getKafkaBufferSize()); | ||
|
|
||
| config = getStreamConfig("topic", "host1", "", ""); | ||
| Assert.assertEquals(KafkaStreamConfigProperties.LowLevelConsumer.KAFKA_BUFFER_SIZE_DEFAULT, config.getKafkaBufferSize()); | ||
|
|
||
| config = getStreamConfig("topic", "host1", "bad value", ""); | ||
| Assert.assertEquals(KafkaStreamConfigProperties.LowLevelConsumer.KAFKA_BUFFER_SIZE_DEFAULT, config.getKafkaBufferSize()); | ||
|
|
||
| // correct config | ||
| config = getStreamConfig("topic", "host1", "100", ""); | ||
| Assert.assertEquals(100, config.getKafkaBufferSize()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetKafkaSocketTimeout() { | ||
| // test default | ||
| KafkaLowLevelStreamConfig config = getStreamConfig("topic", "host1", "",null); | ||
| Assert.assertEquals(KafkaStreamConfigProperties.LowLevelConsumer.KAFKA_SOCKET_TIMEOUT_DEFAULT, config.getKafkaSocketTimeout()); | ||
|
|
||
| config = getStreamConfig("topic", "host1", "",""); | ||
| Assert.assertEquals(KafkaStreamConfigProperties.LowLevelConsumer.KAFKA_SOCKET_TIMEOUT_DEFAULT, config.getKafkaSocketTimeout()); | ||
|
|
||
| config = getStreamConfig("topic", "host1", "","bad value"); | ||
| Assert.assertEquals(KafkaStreamConfigProperties.LowLevelConsumer.KAFKA_SOCKET_TIMEOUT_DEFAULT, config.getKafkaSocketTimeout()); | ||
|
|
||
| // correct config | ||
| config = getStreamConfig("topic", "host1", "", "100"); | ||
| Assert.assertEquals(100, config.getKafkaSocketTimeout()); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it's better to indicate
intto the function name since this is specific to getting an int value. e.g.getIntConfigWithDefaultThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in new diff