Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Trace for performance concern #2057

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Conversation

Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Nov 1, 2017

Add API traceEnabled() into TraceContext
When trace is not enabled, do not log time in BaseOperator
Remove redundant thread local objects

@codecov-io
Copy link

codecov-io commented Nov 2, 2017

Codecov Report

Merging #2057 into master will decrease coverage by 0.04%.
The diff coverage is 52.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2057      +/-   ##
==========================================
- Coverage   69.51%   69.47%   -0.05%     
==========================================
  Files         830      828       -2     
  Lines       40097    39994     -103     
  Branches     5411     5398      -13     
==========================================
- Hits        27874    27786      -88     
+ Misses      10350    10334      -16     
- Partials     1873     1874       +1
Impacted Files Coverage Δ
...com/linkedin/pinot/core/operator/BaseOperator.java 19.04% <11.11%> (-74.29%) ⬇️
.../linkedin/pinot/core/util/trace/TraceCallable.java 62.5% <40%> (-10.23%) ⬇️
...core/query/executor/ServerQueryExecutorV1Impl.java 80.86% <40%> (+0.52%) ⬆️
...m/linkedin/pinot/core/util/trace/TraceContext.java 71.69% <70.45%> (-6.33%) ⬇️
.../linkedin/pinot/core/util/trace/TraceRunnable.java 88.88% <80%> (-2.78%) ⬇️
...inkedin/pinot/common/utils/NamedThreadFactory.java 50% <0%> (-33.34%) ⬇️
...ore/query/scheduler/resources/ResourceManager.java 81.81% <0%> (-13.64%) ⬇️
...pinot/core/operator/docidsets/OrBlockDocIdSet.java 84.9% <0%> (-13.21%) ⬇️
...re/operator/filter/MatchEntireSegmentOperator.java 75% <0%> (-12.5%) ⬇️
...in/pinot/core/query/reduce/NotEqualComparison.java 55.55% <0%> (-11.12%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 404d82f...bc487b2. Read the comment docs.

@Jackie-Jiang Jackie-Jiang force-pushed the refactor_trace branch 2 times, most recently from fb9c19b to 7ee98fe Compare November 2, 2017 00:14
protected final List<Trace> _children = new ArrayList<Trace>();
@Override
public String toString() {
return _key + ": " + _value;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to quote it to get the right json, otherwise we cannot parse it using standard json parsers.

Copy link
Contributor

@mcvsubbu mcvsubbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix and then push. not worth changing it to json object at this time,

Add API traceEnabled() into TraceContext
When trace is not enabled, do not log time in BaseOperator
Remove redundant thread local objects
@Jackie-Jiang Jackie-Jiang merged commit 4ae951b into master Nov 3, 2017
@Jackie-Jiang Jackie-Jiang deleted the refactor_trace branch November 3, 2017 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants