add metadata ttl field to DedupConfig #13636
Open
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13636 +/- ##
=============================================
- Coverage 61.75% 35.19% -26.57%
+ Complexity 207 6 -201
=============================================
Files 2436 2480 +44
Lines 133233 137038 +3805
Branches 20636 21305 +669
=============================================
- Hits 82274 48226 -34048
- Misses 44911 85163 +40252
+ Partials 6048 3649 -2399
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deemoliu
reviewed
Jul 18, 2024
| @@ -52,4 +61,8 @@ public boolean isDedupEnabled() { | |||
| public String getMetadataManagerClass() { | |||
| return _metadataManagerClass; | |||
| } | |||
|
|
|||
| public double getMetadataTTL() { | |||
There was a problem hiding this comment.
this won't work for dedupManager since there is no support for removeExpiredPrimaryKey functionalities in the dedupPartitionManager.
There was a problem hiding this comment.
do we plan to add this feature to dedupPartitionManager as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
UpsertConfig, we want to add ametadataTTLtoDedupConfig. With this config, we can clean up stale dedup metadata.This PR only adds this config. How to use this config to clean up the dedup metadata will be implemented in follow-up PRs