Adjust the default configurations. #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style95
commented
Aug 2, 2022
| @@ -530,9 +530,9 @@ scheduler: | |||
| maxRetriesToGetQueue: "{{ scheduler_maxRetriesToGetQueue | default(13) }}" | |||
| queue: | |||
| # the queue's state Running timeout, e.g. if have no activation comes into queue when Running, the queue state will be changed from Running to Idle and delete the decision algorithm actor | |||
| idleGrace: "{{ scheduler_queue_idleGrace | default('20 seconds') }}" | |||
| idleGrace: "{{ scheduler_queue_idleGrace | default('10 minutes') }}" | |||
There was a problem hiding this comment.
As warmed containers are kept for 10 minutes, it's better to keep the queue as well.
It's relatively safer than containers to keep an idle queue as it uses fewer resources when idle.
| @@ -180,6 +180,13 @@ whisk { | |||
| username: "invoker.user" | |||
| password: "invoker.pass" | |||
| protocol: http | |||
|
|
|||
| resource { | |||
There was a problem hiding this comment.
These are required to run OpenWhisk with other than Ansible.
| @@ -187,6 +187,10 @@ | |||
| "CONFIG_whisk_timeLimit_max": "{{ limit_action_time_max | default() }}" | |||
| "CONFIG_whisk_timeLimit_std": "{{ limit_action_time_std | default() }}" | |||
|
|
|||
| "CONFIG_whisk_concurrencyLimit_min": "{{ limit_action_concurrency_min | default() }}" | |||
There was a problem hiding this comment.
It is missing configuration.
bdoyle0182
approved these changes
Aug 2, 2022
jiangpengcheng
approved these changes
Aug 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #5302 +/- ##
==========================================
+ Coverage 71.46% 76.43% +4.97%
==========================================
Files 238 238
Lines 14183 14183
Branches 574 574
==========================================
+ Hits 10136 10841 +705
+ Misses 4047 3342 -705
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
msciabarra
pushed a commit
to nuvolaris/openwhisk
that referenced
this pull request
Nov 23, 2022
* Adjust the default configurations. * Change the default etcd retention to string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to adjust the default configurations.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: