-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix heisenbug #5027
Fix heisenbug #5027
Conversation
cc1c766
to
8cc41e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #5027 +/- ##
==========================================
- Coverage 83.52% 76.85% -6.67%
==========================================
Files 195 202 +7
Lines 9553 9818 +265
Branches 413 416 +3
==========================================
- Hits 7979 7546 -433
- Misses 1574 2272 +698
Continue to review full report at Codecov.
|
@@ -435,7 +418,7 @@ class ActionLimitsTests extends TestHelpers with WskTestHelpers with WskActorSys | |||
} | |||
|
|||
for (a <- 1 to 10) { | |||
val run = wsk.action.invoke(name, Map("payload" -> "128".toJson)) | |||
val run = wsk.action.invoke(name, Map("payload" -> "128".toJson), blocking = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is supposed to reuse a container, so I change them to blocking calls.
I would re-run all tests multiple times and merge this if there is no further issue. |
Handling
|
bf128ad
to
8f8d40f
Compare
This is to fix the intermittent test failures.
Description
Intermittent test failures due to heisenbugs increase the CI time and make authors run tests multiple times.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: