Fix typos in docs #4279
Merged
Fix typos in docs #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbah
approved these changes
Feb 13, 2019
docs/actions-docker.md
Outdated
| @@ -105,7 +105,7 @@ The instructions that follow show you how to use the OpenWhisk Docker skeleton. | |||
| Notice the use of `--docker` when creating an action. Currently all Docker images are assumed | |||
| to be hosted on Docker Hub. | |||
|
|
|||
| *Note:* It is considered best-practice for production images to be versioned via docker image tags. The absence of a tag will be treated the same as using the tag "latest", which will guarantee to pull from the registry when creating new containers. That contains the possibility of failing because pulling the image fails. For tagged images however, the system will allow a failing pull and gracefully recover it by using the image that is already locally available, making it much more resilient against Dockerhub outages etc. | |||
| *Note:* It is considered best-practice for production images to be versioned via docker image tags. The absence of a tag will be treated the same as using the tag "latest", which will guarantee to pull from the registry when creating new containers. That contains the possibility of failing because pulling the image fails. For tagged images however, the system will allow a failing pull and gracefully recover it by using the image that is already locally available, making it much more resilient against Docker Hub outages etc. | |||
There was a problem hiding this comment.
Can you reword this “Which will guarantee to pull...” and the sentence after it?
There was a problem hiding this comment.
@rabbah, hopefully it makes a little more sense now.
Codecov Report
@@ Coverage Diff @@
## master #4279 +/- ##
==========================================
+ Coverage 59.35% 80.6% +21.25%
==========================================
Files 162 162
Lines 7585 7585
Branches 500 500
==========================================
+ Hits 4502 6114 +1612
+ Misses 3083 1471 -1612
Continue to review full report at Codecov.
|
rabbah
approved these changes
Feb 13, 2019
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
* Fix typos in docs * Re-word Docker paragraph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spelling corrections for markdown files.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: