openamp/libmetal: Check CONFIG_HAVE_ATOMICS instead of HAVE_STDATOMIC_H in atomic.h #9760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_H in atomic.h When we use libmetal with other headers using stdatomic.h, we'll get symbol conflict if we don't enable HAVE_STDATOMIC_H in libmetal. The best solution might be using cmake to detect headers automatically, but we can't. Fortunately we have CONFIG_HAVE_ATOMICS macro now, which can replace HAVE_STDATOMIC_H when we're not using cmake. Note: 2-Steps to use CONFIG_HAVE_ATOMICS 1. Include compiler.h for CONFIG_HAVE_ATOMICS definition 2. Check CONFIG_HAVE_ATOMICS instead of HAVE_STDATOMIC_H Signed-off-by: Zhe Weng <[email protected]>
pkarashchenko
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we use libmetal with other headers using
stdatomic.h, we'll get symbol conflict if we don't enableHAVE_STDATOMIC_Hin libmetal. The best solution might be using cmake to detect headers automatically, but we can't. Fortunately we haveCONFIG_HAVE_ATOMICSmacro now, which can replaceHAVE_STDATOMIC_Hwhen we're not using cmake.Note: 2-Steps to use
CONFIG_HAVE_ATOMICSnuttx/compiler.hforCONFIG_HAVE_ATOMICSdefinitionCONFIG_HAVE_ATOMICSinstead ofHAVE_STDATOMIC_HImpact
config.handatomic.hin libmetalTesting
CI