Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ci break #7842

Merged
merged 6 commits into from
Dec 11, 2022
Merged

Fix the ci break #7842

merged 6 commits into from
Dec 11, 2022

Conversation

xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 commented Dec 10, 2022

Summary

Impact

  • Skip litex/arty_a7 board
  • Fix ccache error

Testing

Pass CI

@xiaoxiang781216 xiaoxiang781216 changed the title ci: Exclude litex/arty_a7 from tools/ci/testlist/risc-v.dat Fix the ci break Dec 10, 2022
to workaround the new toolchain generate the wrong path for
--print-libgcc-file-name and --print-file-name=libm.a:
https://static.dev.sifive.com/dev-tools/freedom-tools/v2020.12/riscv64-unknown-elf-toolchain-10.2.0-2020.12.8-x86_64-linux-ubuntu14.tar.gz

please reference here for more info:
apache#7835

Signed-off-by: Xiang Xiao <[email protected]>
@pkarashchenko
Copy link
Contributor

@xiaoxiang781216 should we ignore macOS build failures?

@xiaoxiang781216
Copy link
Contributor Author

@xiaoxiang781216 should we ignore macOS build failures?

I don't know why macOS build stuck, let' restart the build to try again.

@xiaoxiang781216
Copy link
Contributor Author

@pkarashchenko I found the root cause why macOS stuck, it should work now.

@gustavonihei
Copy link
Contributor

gustavonihei commented Dec 11, 2022

Sorry for all the trouble my latest PRs may have caused.

But changing the prebuilt dir will bring back the #7636 issue.

The prebuilts should be isolated in their own out of tree dir, so that the GitHub action packs everything at the of the workflow.

I've just realized that the tools dir is not the one from the nuttx tree. Sorry for the mistake!

@gustavonihei
Copy link
Contributor

path: ./sources/prebuilt

We need to indicate to the GitHub Cache action the new path to be cached, which is now ./sources/tools.

@xiaoxiang781216
Copy link
Contributor Author

path: ./sources/prebuilt

We need to indicate to the GitHub Cache action the new path to be cached, which is now ./sources/tools.

@gustavonihei done.

@pkarashchenko
Copy link
Contributor

AVR build fails

@xiaoxiang781216
Copy link
Contributor Author

avr doesn't change, I can't understand why avr fail.

@pkarashchenko
Copy link
Contributor

I have Macbook and will try some steps later today

to avoid "avr-objcopy: Bad CPU type in executable" on macOS

Signed-off-by: Xiang Xiao <[email protected]>
@xiaoxiang781216
Copy link
Contributor Author

@pkarashchenko I remove hex generation from build, let's see what happen with the new change.

@pkarashchenko
Copy link
Contributor

@xiaoxiang781216 please fill an issue for hex generation for AVR, so it is not forgotten

@pkarashchenko
Copy link
Contributor

@xiaoxiang781216 somehow I can't merge this PR, because when I press merge button, I'm getting some OAuth error

@xiaoxiang781216 xiaoxiang781216 merged commit 4a84555 into apache:master Dec 11, 2022
@xiaoxiang781216
Copy link
Contributor Author

It's strange, I can merge it.

@pkarashchenko
Copy link
Contributor

pkarashchenko commented Dec 11, 2022

@xiaoxiang781216 I just checked with another PR. This seems to be a mobile app issue since I can merge from a laptop, but not from the GitHub Android app.

@xiaoxiang781216
Copy link
Contributor Author

@xiaoxiang781216 please fill an issue for hex generation for AVR, so it is not forgotten

Here: #7851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants