lib_libvsprintf: fix the float point print bug #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingfish89
force-pushed
the
modify_printf
branch
4 times, most recently
from
e7a3c1e
to
b452d46
Compare
such as code: double value = +0x1.000000000000080000000000p-600;
printf("Hello, World!! %.7g:f64\n", value);
expected output : Hello, World!! 2.40992e-181:f64
but real output : Hello, World!! 2.40992e-B1:f64
the reason: we want printf "18", but the flag of character is 'B'
and 'B' is '0'+18,so printf 'B';
flyingfish89
force-pushed
the
modify_printf
branch
from
b452d46
to
a2cb5f0
Compare
flyingfish89
requested review from
xiaoxiang781216
and removed request for
pkarashchenko
|
Verified on my local machine that this patch can fix #7620 |
| putc('0' + exp, stream); | ||
| /* Parse the ndigs if the value of it bigger than '9' */ | ||
|
|
||
| while (1) |
There was a problem hiding this comment.
Maybe better to
Suggested change
| while (1) | |
| while (ndigits > 0) |
Or something like this. Just from some static alalyzers point of view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
such as code: double value = +0x1.000000000000080000000000p-600;
printf("Hello, World!! %.7g:f64\n", value);
expected output : Hello, World!! 2.40992e-181:f64
but real output : Hello, World!! 2.40992e-B1:f64
the reason: we want printf "18", but the flag of character is 'B'
and 'B' is '0'+18,so printf 'B';
Related issue: #7620
Impact
float printf
Testing
esp32c3 with test code