-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't generate .depend anymore #603
Conversation
@xiaoxiang781216 We have a problem. All chackes are failing because the sim tests are not building. I have the same issue on the PRs that I just submitted. And on Miguel Herranz PR. I merged Miguel's anyway because his ESP32 changes have absolutely nothing to do with sim. By the way, I requested you review of my changes. That is the removal of CONFIG_FS_WRITABLE that we discussed last week. PR #602 |
@xiaoxiang781216 we might want to get the quiet part back for this: https://github.com/apache/incubator-nuttx/blob/master/tools/sethost.sh#L214 |
@xiaoxiang781216 I pulled both this change and the PR from apps to verify that the issue is not similar to the one described in PR602
|
482f1ac
to
d0706b2
Compare
My PR make the fail at graphics/nxglib, I will take time to look at the root cause. |
This is a companion to apps/ PR132. Both should be merged together when this one passes its PR checks. |
d0706b2
to
12d7a21
Compare
Signed-off-by: Xiang Xiao <[email protected]>
12d7a21
to
1d00095
Compare
@xiaoxiang781216 @patacongo This seems to have done something to break a builds. I see the CI is passing here but I am not quite clear why. I see lots of these in the logs |
@btashton I'm having issues with this as well. By pulling all the changes from apps/ and also the yet to be merged PR136 a lot of the issues have been resolved. |
let's see if a revert fixes the CI breakage. #610 |
This reverts commit 79af7fb. Because: * btashton reported some issues in local builds: apache#603 (comment) * this might be related to the current CI breakage: > /bin/sh: 1: /__w/incubator-nuttx/incubator-nuttx/nuttx/tools/mkdeps: not found
I am wondering why this patch can pass ci? |
@yamt the real PR make the break is this one: |
This reverts commit 79af7fb. Because: * btashton reported some issues in local builds: #603 (comment) * this might be related to the current CI breakage: > /bin/sh: 1: /__w/incubator-nuttx/incubator-nuttx/nuttx/tools/mkdeps: not found
Now, with reverting, the build is broken. |
Signed-off-by: Xiang Xiao [email protected]