Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comments on armv7-a smp #2346

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix comments on armv7-a smp #2346

merged 2 commits into from
Nov 20, 2020

Conversation

masayuki2009
Copy link
Contributor

Summary

  • This PR consists of 2 commits
  • commit 1: armv7-a: Fix comments on Cortex-A SGI
    • I noticed that Cortex-A SGI can be masked
    • We thought the SGI is not maskable
    • Although I can not remember how I tested it before
    • It actually works as expected now
  • commit 2: boards: sabre-6quad: Fix README.txt
    • Remove comments on up_idle() which is old information
    • Add L2CC info with QEMU

Impact

  • No impact

Testing

  • Tested with sabre-6quad:smp (QEMU and dev board)
  • Add the following code in up_idle() before calling asm("WFI");
    +  if (0 != up_cpu_index())
    +    {
    +      up_irq_save();
    +    }
  • Run the hello app, you can see "Hello, World!!"
  • But nsh will freeze soon because arm_pause_handler is not called.

@masayuki2009
Copy link
Contributor Author

@patacongo
I confirmed that Cortex-A SGI is maskable.
Though I did not change anything regarding Cortex-A SGI, perhaps I did some mistakes to confirm it before.

xiaoxiang781216
xiaoxiang781216 reviewed Nov 19, 2020
View reviewed changes
TODO Show resolved Hide resolved
@masayuki2009
armv7-a: Fix comments on Cortex-A SGI
e7d5609 
Summary:
- I noticed that Cortex-A SGI can be masked
- We thought the SGI is not maskable
- Although I can not remember how I tested it before
- It actually works as expected now
- Also, fixed the number of remaining bugs in TODO

Impact:
- No impact

Testing:
- Tested with sabre-6quad:smp (QEMU and dev board)
- Add the following code in up_idle() before calling asm("WFI");
+  if (0 != up_cpu_index())
+    {
+      up_irq_save();
+    }
- Run the hello app, you can see "Hello, World!!"
- But nsh will freeze soon because arm_pause_handler is not called.

Signed-off-by: Masayuki Ishikawa <[email protected]>
@masayuki2009
boards: sabre-6quad: Fix README.txt
128b7aa 
Summary:
- Remove comments on up_idle() which is old information
- Add L2CC info with QEMU

Signed-off-by: Masayuki Ishikawa <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit fe8026d into apache:master Nov 20, 2020
@masayuki2009
Copy link
Contributor Author

@btashton
I added the backport/10.0.0 label to this PR.

@Ouss4 Ouss4 added this to to-do in 10.0 backport tracking Nov 21, 2020
@Ouss4 Ouss4 mentioned this pull request Nov 21, 2020
Merged
@Ouss4 Ouss4 moved this from to-do to in-review in 10.0 backport tracking Nov 21, 2020
@btashton btashton moved this from in-review to merged in 10.0 backport tracking Nov 23, 2020
@masayuki2009 masayuki2009 deleted the fix_comments_on_armv7a_smp branch November 23, 2020 08:40
@btashton btashton added this to To-Add in Release Notes - 10.1.0 Apr 12, 2021
@jerpelea jerpelea moved this from To-Add to Minor in Release Notes - 10.1.0 Apr 12, 2021
@jerpelea jerpelea moved this from Minor to Not Applicable in Release Notes - 10.1.0 Apr 16, 2021
@masayuki2009 masayuki2009 mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees
No one assigned
Labels
backport/10.0
Projects
No open projects
10.0 backport tracking
merged
Release Notes - 10.1.0
Not Applicable
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masayuki2009 @xiaoxiang781216