Improvements relating to SAMA5 TSD driver #12131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimJTi
force-pushed
the
SAMA5-TSD-enhancements
branch
2 times, most recently
from
42f261f
to
07b5fd1
Compare
TimJTi
force-pushed
the
SAMA5-TSD-enhancements
branch
from
07b5fd1
to
56ae98c
Compare
xiaoxiang781216
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ongoing work using the SAMA5(D2) touchscreen device demonstrated a number of shortcomings with the existing driver, as well as finding a few style errors.
The main issue was poor touch response as well as interactions with the ADC functions when used in conjunction with the TSD, so there are changes that improve that, although in the end not all may have been necessary but they do make the driver a little more flexible and more predictable in its behaviour.
Impact
Intended that the changes are benign and would not affect anyone using the driver already in a negative way
Testing
Custom board with a SAMA5D27C-D1G and 800x480 LCD with resistive touch.